Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added darktheme for the signup and signin page #330

Merged
merged 5 commits into from
May 25, 2024
Merged

feat: Added darktheme for the signup and signin page #330

merged 5 commits into from
May 25, 2024

Conversation

Ameerjafar
Copy link
Contributor

@Ameerjafar Ameerjafar commented May 21, 2024

Summary

Added the dark theme for signin and signup page

Description

we don't have the dark theme for both signin and signup page we only have a dark theme for home page i have added that one also

Images

signup page
Screenshot 2024-05-25 100600
signin page
Screenshot 2024-05-25 101236

Issue(s) Addressed

Enter the issue number of the bug(s) that this PR fixes

Prerequisites

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 5:13am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 5:13am

@krishnaacharyaa
Copy link
Owner

Thank you Ameerjafar! Your PR title meets our guidelines.

@krishnaacharyaa krishnaacharyaa changed the title feat: Added darktheme for the signup and signin page edit: Added darktheme for the signup and signin page May 21, 2024
@krishnaacharyaa
Copy link
Owner

Hello krishnaacharyaa Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

1 similar comment
@krishnaacharyaa
Copy link
Owner

Hello krishnaacharyaa Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

@krishnaacharyaa krishnaacharyaa changed the title edit: Added darktheme for the signup and signin page feat: Added darktheme for the signup and signin page May 21, 2024
@krishnaacharyaa
Copy link
Owner

Thank you krishnaacharyaa! Your PR title meets our guidelines.

@krishnaacharyaa
Copy link
Owner

Thank you krishnaacharyaa! Your PR title meets our guidelines.

@Ameerjafar Ameerjafar closed this May 21, 2024
@krishnaacharyaa
Copy link
Owner

Thank you Ameerjafar! Your PR title meets our guidelines.

@Ameerjafar Ameerjafar reopened this May 21, 2024
@krishnaacharyaa
Copy link
Owner

Thank you Ameerjafar! Your PR title meets our guidelines.

@Ameerjafar Ameerjafar closed this May 21, 2024
@Ameerjafar Ameerjafar reopened this May 21, 2024
@krishnaacharyaa
Copy link
Owner

Thank you Ameerjafar! Your PR title meets our guidelines.

1 similar comment
@krishnaacharyaa
Copy link
Owner

Thank you Ameerjafar! Your PR title meets our guidelines.

@krishnaacharyaa
Copy link
Owner

@Ameerjafar can you please check in the other places and see if there is requirement to make the fields even darker? Can you check standards of the dark theme forms, and we can change it everywhere, may be in the next PR, i'm fine with that. just once can you check

Copy link

Thank you @krishnaacharyaa! Your PR title meets our guidelines.

@krishnaacharyaa krishnaacharyaa changed the title feat: Added darktheme for the signup and signin page feature: Added darktheme for the signup and signin page May 22, 2024
Copy link

Hello @krishnaacharyaa, thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any questions, kindly check our contributor guidelines.

@github-actions github-actions bot closed this May 22, 2024
@krishnaacharyaa krishnaacharyaa changed the title feature: Added darktheme for the signup and signin page feat: Added darktheme for the signup and signin page May 22, 2024
Copy link

Thank you @krishnaacharyaa! Your PR title meets our guidelines.

@github-actions github-actions bot reopened this May 22, 2024
@Ameerjafar Ameerjafar closed this May 23, 2024
@Ameerjafar Ameerjafar reopened this May 24, 2024
@Ameerjafar
Copy link
Contributor Author

@krishnaacharyaa i have just reopned the pr

@krishnaacharyaa
Copy link
Owner

@Ameerjafar

Did you address the below?

@Ameerjafar can you please check in the other places and see if there is requirement to make the fields even darker? Can you check standards of the dark theme forms, and we can change it everywhere, may be in the next PR, i'm fine with that. just once can you check

I mean input fields when i say fields

Copy link

Hey @Ameerjafar! Thanks for sticking to the guidelines! High five! 🙌🏻

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging this,
For consistency can you please add these newly added variable color to be used in the add-blog page aswell?

image And make the require changes to add consitency

@krishnaacharyaa krishnaacharyaa merged commit 82c4b55 into krishnaacharyaa:main May 25, 2024
3 checks passed
@Ameerjafar
Copy link
Contributor Author

@krishnaacharyaa ok sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Dark theme for both signin and signup page
2 participants