refac: prepare circle stark #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
batzor,
dongchangYoo,
fakedev9999,
GideokKim and
ashjeong
chokobole
force-pushed
the
refac/prepare-circle-stark
branch
from
45af7d4 to
3e4802c
Compare
ashjeong
reviewed
Jul 29, 2024
There was a problem hiding this comment.
3e4802c?diff=split&w=0
If I'm getting this correct, CirclePoint was created, but since it's technically an affine point, the name and type was changed as such. The title seems to suggest that circle points was combined with affine points. Perhaps "change circle point to affine point" would be better?
chokobole
force-pushed
the
refac/prepare-circle-stark
branch
from
3e4802c to
e5a3df3
Compare
chokobole
force-pushed
the
refac/prepare-circle-stark
branch
from
e5a3df3 to
8095d3b
Compare
fakedev9999
reviewed
Jul 30, 2024
|
I understand that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is made to prepare for circle stark