Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: prepare circle stark #493

Merged
merged 10 commits into from
Jul 30, 2024
Merged

refac: prepare circle stark #493

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f6413f9
feat(math): add `CirclePoint::Double(InPlace)()`
chokobole Jul 27, 2024
c8f48cd
refac: change `Fold()` to only fold into `f(X_evens) + X * f(X_odds)`
chokobole Jul 27, 2024
4ddf18c
refac(math): rename namespace `stark` to `m31`
chokobole Jul 27, 2024
392c3fb
refac(math): make affine point multiplication flexible
chokobole Jul 27, 2024
46c7386
refac(math): add `final` keyword to `CirclePoint`
chokobole Jul 27, 2024
a551eff
refac(math): move `curve_type.h` to `geometry` directory
chokobole Jul 27, 2024
f6e915f
refac(math): remove unused headers
chokobole Jul 27, 2024
6b0e9f7
refac: move points related headers to `tachyon/math/geometry`
chokobole Jul 27, 2024
468646f
fix(math): use + instead of * for `ScalarMul()`
chokobole Jul 27, 2024
8095d3b
refac: change `CirclePoint` to `AffinePoint`
chokobole Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tachyon/math/base/semigroups.h
View file
Open in desktop
fakedev9999 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -320,25 +320,25 @@ class AdditiveSemigroup {
case 2:
return Double();
case 3:
return Double() * g;
return Double() + g;
case 4:
return Double().Double();
case 5: {
AddResult g4 = Double();
g4.DoubleInPlace();
return g4 * g;
return g4 + g;
}
case 6: {
AddResult g2 = Double();
AddResult g4 = g2;
g4.DoubleInPlace();
return g4 * g2;
return g4 + g2;
}
case 7: {
AddResult g2 = Double();
AddResult g4 = g2;
g4.DoubleInPlace();
return g4 * g2 * g;
return g4 + g2 + g;
}
default:
return DoScalarMul(BigInt<1>(scalar));
Expand Down