Katib updates #11
Merged
Katib updates #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kromanow94
reviewed
Sep 25, 2024
charts/kubeflow/templates/katib/user-roles/clusterrole.kubeflow-katib-admin.yaml
Outdated
Show resolved
Hide resolved
|
@MaxKavun can you investigate this error? I got it using the |
|
@kromanow94 that was tested and fixed |
…fix secret refences
MaxKavun
added a commit
that referenced
this pull request
Sep 27, 2024
* Katib manifests * updated katib cert/issuer templating * updated katib webhook templating * Update Chart.yaml * sync work * add katib example experiment * Katib updates (#11) * Update cluster roles * Fix a few indentations * fix yaml complaints * Add condition to execute script only on primary node * Update template name and fix the bug * Remove check on script since it's only for replication architecture; fix secret refences * Fix lint * Add maintainers * Rename file to appropriate format --------- Co-authored-by: Corey Ricketts <cricketts@ncl.com> Co-authored-by: Corey Ricketts <495237+doncorsean@users.noreply.github.com> Co-authored-by: Max <maxkavun@outlook.com> Co-authored-by: Maksim Kavun <maksim.kavun@contractors.roche.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
user roles update and values fixes
Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-onlymake test