-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add katib to Helm Chart and update example/helm #8
Conversation
@@ -19,6 +19,21 @@ pipelines: | |||
secretKeyRef: | |||
name: mlpipeline-minio-artifact | |||
|
|||
katib: | |||
dbmanager: | |||
config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to create default db configuration since we use the same secrets/host for
- pipeline component
- katib
And add ability to override for each component ? I see this is quite common approach to avoid repeating the same configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea but let's handle that as a separate issue.
@@ -4,3 +4,25 @@ auth: | |||
existingSecret: db-credentials | |||
commonLabels: | |||
sidecar.istio.io/inject: "false" | |||
|
|||
initdbScripts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also not sure if this is right approach to tight such scripts with database deployment itself
Bitnami mentions it's only for fresh instance and first boot, should we consider a separate Job for database initialisation instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for example configuration. Having this in mind, it should be fine. Our main product is the Helm Chart and the example configuration is just for reference. But, we should document this.
I created an issue for documentation here: #10
Please also generate the kubeflow/manifests for Kubeflow 1.8 with Kustomize and have a look if there any differences between the generated Helm Chart and the generated manifests Kustomize. You can use this example
|
* Update cluster roles * Fix a few indentations * fix yaml complaints * Add condition to execute script only on primary node * Update template name and fix the bug * Remove check on script since it's only for replication architecture; fix secret refences
@MaxKavun can you just fix the CICD for |
Description
I discussed with @doncorsean that I wanted to do some changes and testing for his original PR in #6. We aligned that I'll take his branch and put my changes on it top of it to honor his contribution and move forward.
I did some changes and testing and from the general perspective it seems to be working but we need a closer look. I asked @MaxKavun from my team to have a look at what's happening here, compare what we have with what we expect and possibly make some changes for formatting, parameterization and readability.
Other contributions in form of testing, suggestions, or even PRs to this PR are also welcomed!
Things already included
Experiments
,Suggestions
,Trials
to the Kubeflow Helm Chart.example/helm/katib-experiment.random.yaml
.values.yaml
for MySQL containsinitdbScripts
that addskatib
databse.example/helm/values.kubeflow.yaml
but with different database.Todo
charts/kubeflow/templates/katib/user-roles/*
, maybe more).values.yaml::katib.config
- cleanup needed and possibly there are some differences between upstream 1.8.0 and this.