Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add visual treatment for past journeys #323

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 9, 2024

TL;DR

Added visual treatment for past journeys and optimized time text updates in the journey planner.

What changed?

  • Added visual treatment for past journeys by reducing opacity and using a muted color scheme
  • Fixed content alpha propagation for transport mode icons and badges
  • Optimized time text updates to only trigger when journeys are present
  • Moved time text updates to run on the IO dispatcher
  • Fixed color handling for alerts in expanded journey cards
  • Improved text color handling when custom colors are provided

How to test?

  1. View journey cards for past trips and verify they appear faded
  2. Check that transport mode icons maintain full opacity
  3. Monitor CPU usage during time text updates
  4. Verify alert colors appear correctly in expanded journey cards
  5. Test custom text colors to ensure proper rendering

Why make this change?

To improve user experience by clearly distinguishing past journeys from upcoming ones, while also optimizing performance by reducing unnecessary UI updates. The changes also ensure consistent visual hierarchy through proper opacity handling and color management.

Screenshots

Light Dark
Screenshot_20241109_135259 Screenshot_20241109_135308
Screenshot_20241109_135249 Screenshot_20241109_135315

Copy link
Owner Author

ksharma-xyz commented Nov 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz changed the title UI: Past Journey color to be different UI: Add visual treatment for past journeys Nov 9, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 9, 2024 02:52
@ksharma-xyz ksharma-xyz merged commit aec8f57 into main Nov 9, 2024
3 checks passed
Copy link
Owner Author

Merge activity

  • Nov 8, 9:53 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-09-ui_past_journey_color_to_be_different branch November 9, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant