Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve journey card layout and time formatting #324

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 9, 2024

TL;DR

Improved journey card UI components and time formatting for better accessibility and visual consistency.

What changed?

  • Added singular/plural handling for minute displays (e.g., "1 min ago" vs "2 mins ago")
  • Enhanced journey card components with semantic merging for better accessibility
  • Introduced new SmallButton and TextWithIcon reusable components
  • Standardized padding and spacing in journey card layouts
  • Improved alert button styling and interaction
  • Adjusted vertical spacing between journey legs

How to test?

  1. Navigate to the trip planner
  2. Check journey cards in both collapsed and expanded states
  3. Verify time displays correctly handle singular/plural cases
  4. Test alert button interactions
  5. Confirm accessibility features work with screen readers
  6. Verify consistent spacing between journey legs and components

Why make this change?

To improve the user experience by making the journey card more accessible, visually consistent, and grammatically correct. The changes also reduce code duplication through component reuse and make the UI more maintainable.

Copy link
Owner Author

ksharma-xyz commented Nov 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz force-pushed the 11-09-ui_update_textwithicon branch from 198c4ed to b0929af Compare November 9, 2024 02:48
@ksharma-xyz ksharma-xyz changed the title UI: Update TextWithIcon UI: Improve journey card layout and time formatting Nov 9, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 9, 2024 02:53
@ksharma-xyz ksharma-xyz changed the base branch from 11-09-ui_past_journey_color_to_be_different to graphite-base/324 November 9, 2024 02:53
@ksharma-xyz ksharma-xyz force-pushed the 11-09-ui_update_textwithicon branch from b0929af to e0fda80 Compare November 9, 2024 02:53
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/324 to main November 9, 2024 02:54
@ksharma-xyz ksharma-xyz force-pushed the 11-09-ui_update_textwithicon branch from e0fda80 to d421692 Compare November 9, 2024 02:54
@ksharma-xyz ksharma-xyz merged commit 2d4896b into main Nov 9, 2024
3 checks passed
Copy link
Owner Author

Merge activity

  • Nov 8, 10:00 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-09-ui_update_textwithicon branch November 9, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant