Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: Add journey and trip tracking events #463

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 17, 2024

TL;DR

Refactored analytics tracking to include more detailed event properties and improved event handling across journey interactions.

What changed?

  • Modified Analytics interface to handle event properties directly through AnalyticsEvent
  • Added new analytics events for journey card expand/collapse with hasStarted property
  • Updated DateTimeSelectEvent to use journeyOption instead of type
  • Added analytics tracking for journey alerts, save trip actions, and date/time selections
  • Created dedicated TimeTableAnalytics.kt file for journey card tracking functions
  • Added analytics tracking when accessing the date/time selector

How to test?

  1. Navigate through the time table screen and verify analytics events are fired:
    • Expand/collapse journey cards
    • Select different dates/times
    • Save trips
    • View journey alerts
  2. Check Firebase Analytics dashboard to confirm events are logged with correct properties
  3. Verify reverse trip functionality triggers appropriate analytics events

Why make this change?

To provide more comprehensive analytics data for user interactions, making it easier to track user behavior and improve the journey planning experience. The standardized event tracking will help better understand how users interact with time tables and journey planning features.

@ksharma-xyz ksharma-xyz changed the title Add click events for TimeTableScreen Analytics: Add journey and trip tracking events Dec 17, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 17, 2024 05:52
@ksharma-xyz ksharma-xyz force-pushed the 12-17-add_click_analytics_events branch from d1b9294 to 92286b7 Compare December 18, 2024 06:43
@ksharma-xyz ksharma-xyz force-pushed the 12-17-add_click_events_for_timetablescreen branch from c4f4e84 to cee56a9 Compare December 18, 2024 06:43
Base automatically changed from 12-17-add_click_analytics_events to main December 18, 2024 22:26
@ksharma-xyz ksharma-xyz force-pushed the 12-17-add_click_events_for_timetablescreen branch from cee56a9 to 2bf5da2 Compare December 18, 2024 22:29
@ksharma-xyz ksharma-xyz force-pushed the 12-17-add_click_events_for_timetablescreen branch from 2bf5da2 to a178b2f Compare December 19, 2024 07:37
@ksharma-xyz ksharma-xyz merged commit 39e121f into main Dec 19, 2024
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 12-17-add_click_events_for_timetablescreen branch December 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant