Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Rename AppPlatformType to DevicePlatformType and refactor AppInfo #466

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Core: Rename AppPlatformType to DevicePlatformType and refactor AppInfo #466

merged 1 commit into from
Dec 23, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 18, 2024 •
edited
Loading

Refactors app info interface and implementations:

  • Converts isDebug() from a function to a property
  • Renames AppPlatformType to DevicePlatformType for clarity
  • Renames type property to devicePlatformType
  • Renames version property to appVersion

This was referenced Dec 18, 2024
Merged
Merged
Merged
Merged
@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Dec 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz mentioned this pull request Dec 18, 2024
Merged
@ksharma-xyz ksharma-xyz changed the title Analytics: updates to AppInfo - make isdebug a field instead of function - rename to DevicePlatformType Core: Rename AppPlatformType to DevicePlatformType and refactor AppInfo Dec 18, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 18, 2024 07:34
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from c59c591 to 39f8c95 Compare December 18, 2024 09:52
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from 97d82f1 to 77bd90f Compare December 18, 2024 22:29
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from 39f8c95 to d091cb3 Compare December 18, 2024 22:29
This was referenced Dec 18, 2024
Merged
Merged
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from 77bd90f to eab4f3a Compare December 23, 2024 11:35
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from d091cb3 to e341a6a Compare December 23, 2024 11:35
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from eab4f3a to 4406bc7 Compare December 23, 2024 11:42
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from e341a6a to 690d2b3 Compare December 23, 2024 11:42
This was referenced Dec 23, 2024
Merged
Merged
Merged
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from 4406bc7 to 7090b82 Compare December 23, 2024 11:55
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from 690d2b3 to c4bde5a Compare December 23, 2024 11:55
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from 7090b82 to f020ce4 Compare December 23, 2024 11:59
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from c4bde5a to 44a50a8 Compare December 23, 2024 11:59
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from f020ce4 to 7ce7089 Compare December 23, 2024 12:10
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from 44a50a8 to 3dc628e Compare December 23, 2024 12:11
@ksharma-xyz ksharma-xyz force-pushed the 12-18-update_appinfo_and_add_app_start_events_for_analytics branch from 7ce7089 to 356b99d Compare December 23, 2024 21:21
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from 3dc628e to a20b4e2 Compare December 23, 2024 21:22
Base automatically changed from 12-18-update_appinfo_and_add_app_start_events_for_analytics to main December 23, 2024 21:30
@ksharma-xyz
Analytics: updates to AppInfo
f56731b 
- make isdebug a field instead of function
- rename to DevicePlatformType
@ksharma-xyz ksharma-xyz force-pushed the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch from a20b4e2 to f56731b Compare December 23, 2024 23:09
@ksharma-xyz ksharma-xyz added this to the v1.1.1 milestone Dec 23, 2024
@ksharma-xyz ksharma-xyz merged commit 871f8db into main Dec 23, 2024
2 checks passed
@ksharma-xyz Graphite App
Copy link
Owner Author

Merge activity

  • Dec 23, 6:20 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 12-18-analytics_updates_to_appinfo_-_make_isdebug_a_field_instead_of_function_-_rename_to_deviceplatformtype branch December 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Krail - NSW Trip Planning
Status: Done
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz