Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates wazero to 1.0.1 #28

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

codefromthecrypt
Copy link
Contributor

This updates wazero to 1.0.0 which begins our compatibility promise.

On behalf of everyone in the community, I want to thank you for trying wazero before we became stable. We will not raise unsolicited pull requests anymore. That said, if any update gives you problems, please feel free to contact us on slack or via a GitHub issue.

Finally, if you would like to share your work, feel free to update our users page!

README.md Outdated Show resolved Hide resolved
@@ -48,9 +47,6 @@ func main() {
_, err = r.InstantiateModule(ctx, compiled,
wazero.NewModuleConfig().WithSysWalltime().WithSysNanotime().WithSysNanosleep().WithRandSource(crand.Reader).WithStdout(os.Stdout).WithStderr(os.Stderr).WithStdin(newNonBlockReader(os.Stdin)).WithFSConfig(fsConfig).WithArgs(append([]string{"arg0"}, args[1:]...)...))
if err != nil {
if exitErr, ok := err.(*sys.ExitError); ok && exitErr.ExitCode() == 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi we no longer return exit 0 from instantiate. that coerces to no error

@ktock
Copy link
Owner

ktock commented Mar 30, 2023

@codefromthecrypt Thanks, LGTM. Could you squash the commits?

This updates [wazero](https://wazero.io/) to [1.0.0](https://github.com/tetratelabs/wazero/releases/tag/v1.0.0) which begins our compatibility promise.

On behalf of everyone in the community, I want to thank you for trying wazero before we became stable. We will not raise unsolicited pull requests anymore. That said, if any update gives you problems, please feel free to contact [us](https://wazero.io/community/) on slack or via a GitHub issue.

Finally, if you would like to share your work, feel free to update our [users page](https://github.com/tetratelabs/wazero/blob/main/site/content/community/users.md)!

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Contributor Author

@ktock squashed!

@ktock
Copy link
Owner

ktock commented Mar 30, 2023

Thanks!

@ktock ktock merged commit 746e2fc into ktock:main Mar 30, 2023
@codefromthecrypt codefromthecrypt deleted the wazero-1.0.1 branch March 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants