Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates wazero to 1.0.1 #28

Merged
merged 1 commit into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ The following shows the techniqual details:

## Similar projects

There are several container runtimes support running WASM applications but they don't run containers on WASM.
There are several container runtimes support running WASM applications, but they don't run containers on WASM.

- WASM on container runtimes
- Docker+Wasm integration: https://docs.docker.com/desktop/wasm/
Expand All @@ -200,7 +200,7 @@ There are several container runtimes support running WASM applications but they
- crun: https://github.com/containers/crun
- krustlet: https://github.com/krustlet/krustlet

There are emulators that support running linux on WASM but they don't support WASI.
There are emulators that support running linux on WASM, but they don't support WASI.

- x86 on WASM
- v86: https://github.com/copy/v86
Expand All @@ -210,7 +210,7 @@ There are emulators that support running linux on WASM but they don't support WA

## Additional Documents

- [`./examples/`](./examples/): Examples (python, php, non-riscv64 image, etc.)
- [`./examples/`](./examples): Examples (python, php, non-riscv64 image, etc.)

## Acknowledgement

Expand Down
2 changes: 1 addition & 1 deletion tests/wazero/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ module github.com/ktock/container2wasm/examples/wazero

go 1.19

require github.com/tetratelabs/wazero v1.0.0-rc.2
require github.com/tetratelabs/wazero v1.0.1
4 changes: 2 additions & 2 deletions tests/wazero/go.sum
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github.com/tetratelabs/wazero v1.0.0-rc.2 h1:OA3UUynnoqxrjCQ94mpAtdO4/oMxFQVNL2BXDMOc66Q=
github.com/tetratelabs/wazero v1.0.0-rc.2/go.mod h1:wYx2gNRg8/WihJfSDxA1TIL8H+GkfLYm+bIfbblu9VQ=
github.com/tetratelabs/wazero v1.0.1 h1:xyWBoGyMjYekG3mEQ/W7xm9E05S89kJ/at696d/9yuc=
github.com/tetratelabs/wazero v1.0.1/go.mod h1:wYx2gNRg8/WihJfSDxA1TIL8H+GkfLYm+bIfbblu9VQ=
4 changes: 0 additions & 4 deletions tests/wazero/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (

"github.com/tetratelabs/wazero"
"github.com/tetratelabs/wazero/imports/wasi_snapshot_preview1"
"github.com/tetratelabs/wazero/sys"
)

func main() {
Expand Down Expand Up @@ -48,9 +47,6 @@ func main() {
_, err = r.InstantiateModule(ctx, compiled,
wazero.NewModuleConfig().WithSysWalltime().WithSysNanotime().WithSysNanosleep().WithRandSource(crand.Reader).WithStdout(os.Stdout).WithStderr(os.Stderr).WithStdin(newNonBlockReader(os.Stdin)).WithFSConfig(fsConfig).WithArgs(append([]string{"arg0"}, args[1:]...)...))
if err != nil {
if exitErr, ok := err.(*sys.ExitError); ok && exitErr.ExitCode() == 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi we no longer return exit 0 from instantiate. that coerces to no error

return
}
panic(err)
}
return
Expand Down