Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7586: improve parsing of supported media types #4410

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

anton-erofeev
Copy link
Contributor

@anton-erofeev anton-erofeev commented Oct 17, 2024

Subsystem
Core, http

Motivation
https://youtrack.jetbrains.com/issue/KTOR-7586

Solution
improved parsing of supported media types

@osipxd osipxd self-requested a review October 18, 2024 09:04
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🚀
I have some ideas on how to improve it. Please, check the comments.

ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
@anton-erofeev
Copy link
Contributor Author

Thank you for your contribution! 🚀 I have some ideas on how to improve it. Please, check the comments.

good points, thanks, please review the fixes

@anton-erofeev anton-erofeev requested a review from osipxd October 22, 2024 18:49
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a great job!
Just a few minor comments left

ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
ktor-http/common/test/io/ktor/tests/http/MimesTest.kt Outdated Show resolved Hide resolved
ktor-http/common/src/io/ktor/http/Mimes.kt Outdated Show resolved Hide resolved
@osipxd
Copy link
Member

osipxd commented Oct 29, 2024

Thank you, LGTM. I'll merge this PR to 3.1.0-eap 🎉

@osipxd osipxd changed the base branch from main to 3.1.0-eap October 30, 2024 09:50
@osipxd osipxd merged commit 8ee8e9b into ktorio:3.1.0-eap Oct 30, 2024
8 of 13 checks passed
osipxd added a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Nov 8, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 14, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Nov 16, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Nov 22, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 25, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 27, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 28, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Nov 29, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
e5l pushed a commit that referenced this pull request Dec 3, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Dec 6, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Dec 12, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
osipxd added a commit that referenced this pull request Dec 19, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Stexxe pushed a commit that referenced this pull request Dec 24, 2024
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants