-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-7586: improve parsing of supported media types #4410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🚀
I have some ideas on how to improve it. Please, check the comments.
good points, thanks, please review the fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a great job!
Just a few minor comments left
Thank you, LGTM. I'll merge this PR to 3.1.0-eap 🎉 |
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Co-authored-by: Osip Fatkullin <osip.fatkullin@jetbrains.com>
Subsystem
Core, http
Motivation
https://youtrack.jetbrains.com/issue/KTOR-7586
Solution
improved parsing of supported media types