Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-7586 Fix MimesTest doesn't compile on JS target #4438

Merged
merged 1 commit into from
Oct 31, 2024
Merged

KTOR-7586 Fix MimesTest doesn't compile on JS target #4438

merged 1 commit into from
Oct 31, 2024

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Oct 30, 2024 •
edited
Loading

The problem was introduced with #4410

Build fails with an error because of spaces in test names

e: file:///mnt/agent/work/8d547b974a7be21f/ktor-http/common/test/io/ktor/tests/http/MimesTest.kt:12:5 Name contains illegal chars that cannot appear in JavaScript identifier.
e: file:///mnt/agent/work/8d547b974a7be21f/ktor-http/common/test/io/ktor/tests/http/MimesTest.kt:21:5 Name contains illegal chars that cannot appear in JavaScript identifier.
e: file:///mnt/agent/work/8d547b974a7be21f/ktor-http/common/test/io/ktor/tests/http/MimesTest.kt:28:5 Name contains illegal chars that cannot appear in JavaScript identifier.

@osipxd osipxd self-assigned this Oct 30, 2024
@osipxd osipxd requested a review from bjhham October 30, 2024 13:36
@osipxd osipxd merged commit a65ff10 into 3.1.0-eap Oct 31, 2024
11 of 14 checks passed
@osipxd osipxd deleted the osipxd/fix-js-tests branch October 31, 2024 10:12
osipxd added a commit that referenced this pull request Oct 31, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
2f9fcfd
osipxd added a commit that referenced this pull request Nov 8, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
c69d8ff
e5l pushed a commit that referenced this pull request Nov 13, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
4460fd0
e5l pushed a commit that referenced this pull request Nov 14, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
1302f9b
osipxd added a commit that referenced this pull request Nov 16, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
8064642
e5l pushed a commit that referenced this pull request Nov 19, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
d860c68
osipxd added a commit that referenced this pull request Nov 22, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
07426d3
e5l pushed a commit that referenced this pull request Nov 25, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
6d61fe2
e5l pushed a commit that referenced this pull request Nov 26, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
5518e2f
e5l pushed a commit that referenced this pull request Nov 27, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
9760b42
e5l pushed a commit that referenced this pull request Nov 28, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
fdadffd
e5l pushed a commit that referenced this pull request Nov 29, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
66e55da
e5l pushed a commit that referenced this pull request Dec 3, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
5be0fbb
e5l pushed a commit that referenced this pull request Dec 3, 2024
@osipxd @e5l
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
06e4447
osipxd added a commit that referenced this pull request Dec 6, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
d5ea88a
osipxd added a commit that referenced this pull request Dec 11, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
2726112
osipxd added a commit that referenced this pull request Dec 12, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
31fedde
osipxd added a commit that referenced this pull request Dec 19, 2024
@osipxd
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
5e238ab
Stexxe pushed a commit that referenced this pull request Dec 24, 2024
@osipxd @Stexxe
KTOR-7586 Fix MimesTest doesn't compile on JS target (#4438)
22adbc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhham bjhham bjhham approved these changes

Assignees

@osipxd osipxd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osipxd @bjhham