Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack windows tests to use rustls to avoid openssl breakage #1202

Merged
merged 25 commits into from
May 5, 2023
Merged

Conversation

clux
Copy link
Member

@clux clux commented Apr 16, 2023

Works around #1191 with a hacky rustls switch on windows only.
This does mean we don't run all-features tests on windows, but that's better than the current (where it crashes early and we don't even know).

Should ideally experiment with getting openssl working, but don't have it in me atm. Just want ci to become green, without turning the thing off completely.

Only functional change here that noticeable outside CI disabling a default TLS stack from kube-client because this is chosen from the facade crate instead.

Few minor CI tweaks while in the area:

  • avoid running ci for *.md changes (seems to work but can't avoid plain unit tests atm because they are 'required statuses' for github - and removing that would be awkward)
  • remove unwanted codecov status checks (they were introduced by the service as it upgraded..) -- got some of it away

wanted to test a thing.

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added this to the 0.83.0 milestone Apr 16, 2023
@clux clux added the changelog-exclude changelog excluded prs label Apr 16, 2023
@clux clux changed the title Path filter CI jobs Path filter CI jobs to relevant extensions Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #1202 (02a8e58) into main (894b508) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   73.52%   73.50%   -0.02%     
==========================================
  Files          68       68              
  Lines        5379     5379              
==========================================
- Hits         3955     3954       -1     
- Misses       1424     1425       +1     

see 1 file with indirect coverage changes

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Path filter CI jobs to relevant extensions CI Work Draft Apr 16, 2023
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title CI Work Draft Move windows tests to rustls to avoid openssl breakage Apr 17, 2023
@clux clux added the automation ci and testing related label Apr 17, 2023
@clux clux marked this pull request as ready for review May 3, 2023 17:57
clux added 3 commits May 3, 2023 20:40
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented May 3, 2023

alright this garbage is finally working. there's some non-standard sed on the windows workers so the hack is even more brittle than what it was originally.

still, it does make ci green and it technically tests most of windows.

@clux clux changed the title Move windows tests to rustls to avoid openssl breakage Hack windows tests to use rustls to avoid openssl breakage May 3, 2023
Copy link
Contributor

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never an end to openssl and plumbing :( This LGTM although ofc I'm not intimately familiar with the entire pipeline yet.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
clux added 5 commits May 5, 2023 09:45
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit 3e7f32e into main May 5, 2023
@clux clux deleted the path-filter branch May 5, 2023 10:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation ci and testing related changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants