-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack windows tests to use rustls
to avoid openssl breakage
#1202
Conversation
wanted to test a thing. Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 73.52% 73.50% -0.02%
==========================================
Files 68 68
Lines 5379 5379
==========================================
- Hits 3955 3954 -1
- Misses 1424 1425 +1 |
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
rustls
to avoid openssl breakage
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
alright this garbage is finally working. there's some non-standard still, it does make ci green and it technically tests most of windows. |
rustls
to avoid openssl breakagerustls
to avoid openssl breakage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never an end to openssl
and plumbing :( This LGTM although ofc I'm not intimately familiar with the entire pipeline yet.
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Works around #1191 with a hacky rustls switch on windows only.
This does mean we don't run all-features tests on windows, but that's better than the current (where it crashes early and we don't even know).
Should ideally experiment with getting openssl working, but don't have it in me atm. Just want ci to become green, without turning the thing off completely.
Only functional change here that noticeable outside CI disabling a default TLS stack from
kube-client
because this is chosen from the facade crate instead.Few minor CI tweaks while in the area:
*.md
changes (seems to work but can't avoid plain unit tests atm because they are 'required statuses' for github - and removing that would be awkward)