Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher::Config: Derive Clone + Debug + PartialEq #1206

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

clux
Copy link
Member

@clux clux commented Apr 19, 2023

fixes #1205
Default is manually implemented from before.

fixes #1205

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-fix changelog fix category for prs label Apr 19, 2023
@clux clux modified the milestones: 0.83.0, 0.82.2 Apr 19, 2023
@nightkr
Copy link
Member

nightkr commented Apr 19, 2023

Huh, the Windows error looks very unrelated.

@clux
Copy link
Member Author

clux commented Apr 19, 2023

Yeah, ignore the windows error it's been failing for a while, and i'm trying to work around it in #1202

@clux clux merged commit 03489fb into main Apr 19, 2023
@clux clux deleted the watcher-derive branch April 19, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The kube-runtime watcher::Config is missing basic traits
2 participants