This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Adding compatibility for API supporting HPA #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tenzen-y Once this is merged, we can create a new release in kubeflow/common |
tenzen-y
reviewed
Jan 19, 2023
pkg/apis/common/v1/types.go
Outdated
Comment on lines
69
to
71
| // A label selector is a label query over a set of resources. The result of matchLabels and | ||
| // matchExpressions are ANDed. An empty label selector matches all objects. A null | ||
| // label selector matches no objects. |
There was a problem hiding this comment.
Maybe, these are selector, not label selector?
tenzen-y
reviewed
Jan 19, 2023
|
@johnugeorge Can you rerun @@ -231,7 +231,7 @@ func schema_pkg_apis_common_v1_ReplicaSt
},
"selector": {
SchemaProps: spec.SchemaProps{
- Description: "A Selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty Selector matches all objects. A null Selector matches no objects.",
+ Description: "A label selector is a label query over a set of resources. The result of matchLabels and matchExpressions are ANDed. An empty label selector matches all objects. A null label selector matches no objects.",
Type: []string{"string"},
Format: "",
},
./hack/../pkg is out of date. Please run hack/update-codegen.sh |
|
/lgtm cancel |
|
/lgtm |
terrytangyuan
approved these changes
Jan 20, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LabelSelectorfield is restored to provide compatibility with the current API. Instead,Selectorfield will be used for HPA featureRelated: #197 kubeflow/training-operator#1725