Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib experiment detail page 500 error after refresh #1967

Closed
shaowei-su opened this issue Sep 30, 2022 · 10 comments
Closed

Katib experiment detail page 500 error after refresh #1967

shaowei-su opened this issue Sep 30, 2022 · 10 comments
Labels

Comments

@shaowei-su
Copy link
Contributor

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Katib experiment detail page can be accessed after a given namespace (non default one) is chosen, however, upon page refresh or direct access page URL e.g https://service-name/katib/experiment/exp-name, UI will throw out 500 error.
Screen Shot 2022-09-29 at 20 02 01

By checking the requested URL, it seems that the actual API request sent is https://service-name/katib/fetch_hp_job_info/?experimentName=exp-name&namespace=kubeflow-user where the namespace is default to namespace=kubeflow-user.

What did you expect to happen:

The experiment detail page should able to refresh and directly accessible.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Katib version (check the Katib controller image version): v0.13.0
  • Kubernetes version: (kubectl version): N/A
  • OS (uname -a): N/A

Impacted by this bug? Give it a 👍 We prioritize the issues with the most 👍

@tenzen-y
Copy link
Member

@shaowei-su Thanks for reporting this!
Did you get the same error with katib v0.14.0?

@shaowei-su
Copy link
Contributor Author

Hi @tenzen-y yeah I just tried v0.14.0 UI component and it failed with the same error. Are you able to reproduce this on your side?

@tenzen-y
Copy link
Member

tenzen-y commented Nov 2, 2022

@shaowei-su Sorry for the late response.
In my local kind cluster, I faced that issue.

2022-11-03 4 52 36

@tenzen-y
Copy link
Member

tenzen-y commented Nov 2, 2022

@kimwnasptd Can you help with fixing this bug?

@johnugeorge
Copy link
Member

/cc @elenzio9

Can you please take a look at this? This seems to be a blocker for new UI

Ref: #1982 (comment)

@kimwnasptd
Copy link
Member

Thanks for the ping!

Yes we'll take a look at this one within the next week.

@johnugeorge
Copy link
Member

Thanks @kimwnasptd

Related: #1983

@elenzio9
Copy link
Contributor

elenzio9 commented Nov 7, 2022

The problem was that the link itself didn't have information about the selected namespace. To solve this, we added the namespace variable as an extra query parameter to the route: { path: 'experiment/:namespace/:experimentName',component: ExperimentDetailsComponent }. So each time the detail page is initialized both the namespace and the name variables will be set using the information from the currently activated route.

elenzio9 added a commit to arrikto/katib that referenced this issue Nov 7, 2022
Fix 500 error when refreshing KWA's detail page by also considering the
namespace variable as a query param.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Nov 7, 2022
Fix 500 error when refreshing KWA's detail page by also adding the
namespace variable as a query param to the route.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd
Copy link
Member

Small clarification, the above problem only happened in the standalone mode of the UI.

In the app with Kubeflow we don't see this problem, since the CentralDashboard is always propagating the selected namespace in the underlying app.

elenzio9 added a commit to arrikto/katib that referenced this issue Nov 11, 2022
Fix 500 error when refreshing KWA's detail page by also adding the
namespace variable as a query param to the route.

Signed-off-by: Elena Zioga <elena@arrikto.com>
google-oss-prow bot pushed a commit that referenced this issue Nov 14, 2022
Fix 500 error when refreshing KWA's detail page by also adding the
namespace variable as a query param to the route.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
@johnugeorge
Copy link
Member

Fixed by #2001

Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants