frontend: Fix 500 error after detail page refresh (#1967)

[elenzio9]

Fix 500 error when refreshing KWA's detail page by also adding the namespace variable as a query parameter to the route.

Related issue: #1967

Signed-off-by: Elena Zioga elena@arrikto.com

[coveralls]

Coverage increased (+0.3%) to 73.737% when pulling 9e2ed03 on arrikto:feature-elena-kwa-detail-page-error-fix into c25518a on kubeflow:master.

[johnugeorge]

Thanks @elenzio9

@shaowei-su Can you check this out in your env if it works ?

[kimwnasptd]

@elenzio9 thanks for the PR!

With a quick glance I see that you only changed the files of the page that handles an Experiment. Should we also change the main page with the table that redirects users to the details page of an Experiment? To ensure the correct link is used there as well

[elenzio9]

@elenzio9 thanks for the PR!

With a quick glance I see that you only changed the files of the page that handles an Experiment. Should we also change the main page with the table that redirects users to the details page of an Experiment? To ensure the correct link is used there as well

I've also updated this page as you can see here: https://github.com/kubeflow/katib/pull/2001/files#diff-4e45400d0d644ac998f731d708df6edd6667d51b19c7be069e2522dfcef3f137R89

[shaowei-su]

Thanks @elenzio9 @johnugeorge , just tested this branch offline and the 500 error is fixed. Huge thanks for your timely fix 👍

[shaowei-su]

Actually, I found an issue with loading the visualized graph if the experiment is in "running" state (6 out of 10 trials are already succeeded but failed to load) :

[elenzio9]

Actually, I found an issue with loading the visualized graph if the experiment is in "running" state (6 out of 10 trials are already succeeded but failed to load)

Since the above issue is related to the experiment graph, it would be helpful to create another issue and describe everything there. Thank you!

[johnugeorge]

@

Actually, I found an issue with loading the visualized graph if the experiment is in "running" state (6 out of 10 trials are already succeeded but failed to load) :

@shaowei-su Can you create a separate issue to track this? This PR is good to go

/assign @kimwnasptd

[kimwnasptd]

@elenzio9 can you do a rebase here as well to ensure the unittests are passing as well?

[kimwnasptd]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/new-ui/v1beta1/OWNERS [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment