Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Succeeded trials are not loaded in the experiment graph UI #2013

Closed
johnugeorge opened this issue Nov 16, 2022 · 3 comments
Closed

Bug: Succeeded trials are not loaded in the experiment graph UI #2013

johnugeorge opened this issue Nov 16, 2022 · 3 comments
Assignees
@elenzio9
Labels
lifecycle/stale

Comments

@johnugeorge
Copy link
Member

This issue is track the bug reported in #2001 (comment)

Actually, I found an issue with loading the visualized graph if the experiment is in "running" state (6 out of 10 trials are already succeeded but failed to load) :

/cc @shaowei-su

/assign @elenzio9
@elenzio9
Copy link
Contributor

The reason why this happens is because of this line and specifically the check: !response.includes(',,'), which is responsible for not displaying the graph when the backend response includes ,,. That is, when a trial is in running state. However, this check doesn't consider the case where some of the trials are in succeeded state and the others are in running state. The graph should then show the succeeded trials, but currently the message is still displayed.

One solution is to modify the check by taking into account the state of the trials. This way, when the first trial succeeds, the graph will appear.

elenzio9 added a commit to arrikto/katib that referenced this issue Nov 22, 2022
@elenzio9
frontend: Show the successful trials in the experiment graph (kubeflo…
1b55064 
…w#2013)

* Show the successful trials in the experiment graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Nov 22, 2022
Merged
google-oss-prow bot pushed a commit that referenced this issue Dec 5, 2022
@elenzio9
frontend: Show the successful trials in the experiment graph (#2013) (#…
9fe1bd6 
…2033)

* Show the successful trials in the experiment graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

This was fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenzio9 elenzio9

Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnugeorge @andreyvelich @elenzio9