Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Show the successful trials in the experiment graph (#2013) #2033

Conversation

elenzio9
Copy link
Contributor

@elenzio9 elenzio9 commented Nov 22, 2022

According to #2013, there was a bug about when we display the experiment graph. Specifically, when some of the trials are in succeeded state and others are in running state, the message is still displayed instead of the graph. We fixed it considering the state of the trials. This way, when the first trial succeeds, the graph will appear:

image

…w#2013)

* Show the successful trials in the experiment graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@johnugeorge
Copy link
Member

/cc @shaowei-su

@google-oss-prow
Copy link

@johnugeorge: GitHub didn't allow me to request PR reviews from the following users: shaowei-su.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @shaowei-su

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@shaowei-su shaowei-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tenzen-y
Copy link
Member

/assign @kimwnasptd

@kimwnasptd
Copy link
Member

@tasos-ale could you also help with the review for this?
/cc @tasos-ale

@tasos-ale
Copy link

I tested this PR and everything looks as expected. Thanks, @elenzio9. cc @kimwnasptd
/lgtm

@tenzen-y
Copy link
Member

tenzen-y commented Dec 2, 2022

@kubeflow/wg-automl-leads @kimwnasptd Can we merge this PR with the master branch?

@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd, shaowei-su

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9fe1bd6 into kubeflow:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants