Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the license to pbt #1958

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I added the license to PBT.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 73.431% when pulling 886058b on tenzen-y:update-boilerplate into e02eb6e on kubeflow:master.

@tenzen-y
Copy link
Member Author

@kubeflow/wg-automl-leads PTAL.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 293a785 into kubeflow:master Sep 28, 2022
@tenzen-y tenzen-y deleted the update-boilerplate branch September 28, 2022 02:29
@a9p
Copy link
Contributor

a9p commented Sep 28, 2022

Hey @tenzen-y & @gaocegege! I originally excluded the KF copyright on this file since it is heavily based on / copied from the Ray implementation here. I defer to your expertise, but wanted to surface this point in the event it necessitates changing anything!

@tenzen-y
Copy link
Member Author

tenzen-y commented Sep 29, 2022

Hey @tenzen-y & @gaocegege! I originally excluded the KF copyright on this file since it is heavily based on / copied from the Ray implementation here. I defer to your expertise, but wanted to surface this point in the event it necessitates changing anything!

@a9p Thanks for your response!
We have created other trial images based on other codes, same as the simple-pbt, and added the KF copyright to all trial images.
So we need to add the KF copyright to the simple-pbt.

Although, we might be able to add readme, same as other trial images such as the tf-mnit-with-summaries since it would be good to clarify that the simple-pbt is heavily based on from Ray.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants