Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the documentation for simple-pbt #1978

Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
As discussed in this, I added the documentation for the simple-pbt example.

cc: @a9p @gaocegege

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.431% when pulling 22951d7 on tenzen-y:add-document-for-simple-pbt into 4299856 on kubeflow:master.

Copy link
Contributor

@a9p a9p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on the previous issue and adding these changes!

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a9p, johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

Can you rebase

@tenzen-y

@google-oss-prow google-oss-prow bot merged commit e444ea9 into kubeflow:master Oct 24, 2022
@tenzen-y
Copy link
Member Author

Can you rebase

@tenzen-y

@johnugeorge
hmm. This PR has been merged into the master branch...

@tenzen-y tenzen-y deleted the add-document-for-simple-pbt branch October 24, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants