-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB: Add environment variable option to skip DB table creationˆ #2245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this @lkaybob!
I agree, we should give user capability to skip DB creation.
I left a few comments.
/assign @tenzen-y @johnugeorge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkaybob Thank you for this contribution :)
Totally, LGTM: I left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! @andreyvelich @tenzen-y
I've applied suggestions you left with additional changes to make consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great to me.
@kubeflow/wg-automl-leads Can you approve workflows?
/lgtm
/approve
/lgtm cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkaybob, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for the updates @lkaybob! |
@kubeflow/wg-automl-leads Could you restart CI jobs, |
It's strange why |
a8b8328
to
669d12a
Compare
@andreyvelich I've just rebased my PR, and I will create an issue at kubeflow/website repository to address this change so that I can work on it later. |
This is blocked by #2251 |
@lkaybob Please can you rebase one more time ? |
* Migration -> Initialization * Remove GetBoolEnvOrDefault
669d12a
to
64f0f85
Compare
@andreyvelich I've just rebased the branch. Let's see if the test passes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @lkaybob!
/lgtm
What this PR does / why we need it:
Currently, DB Manager automatically tries to create
observation_logs
table on startup usingCREATE TABLE IF NOT EXISTS
clause. However, this part does not work when DB user does not have enough privilege to create table if DB schema creation is handled by manual admin process.To address this, we have hard-forked the repository and built our own image after commenting out table creation part so far. Since I guess there might be similar need to skip table creation from other than us, I've added an environment variable option to skip table creation along with simple logic to validate
observation_logs
table structure withSELECT
statement.(ml-metadata allows this with option in protobuf text format.)
Which issue(s) this PR fixes
None. I've create pull request directly.
Checklist:
(Need to update list of Environment Variables for Katib Components on Katib DB Manager. I will create additional pull request to address the change on website.)
FYI. I've created an issue for Pipelines(kubeflow/pipelines#10265) where similar improvement could be possible