Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib: Add SKIP_DB_INITIALIZATION variable of Katib DB Manager #3658

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

lkaybob
Copy link
Contributor

@lkaybob lkaybob commented Jan 6, 2024

This follow-up PR reflects a change from kubeflow/katib#2245, which introduced a new environment variable option to skip DB initialization when Katib DB manager is run.

It updates Katib DB Manager part of Environment Variables for Katib Components.

Closes #3656

Copy link

Hi @lkaybob. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lkaybob lkaybob changed the title Add SKIP_DB_INITIALIZATION variable of Katib DB Manager Katib: Add SKIP_DB_INITIALIZATION variable of Katib DB Manager Jan 6, 2024
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @lkaybob!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, lkaybob

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d37ef3c into kubeflow:master Jan 8, 2024
6 checks passed
@lkaybob lkaybob deleted the update-katib-env branch January 9, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation of "Environment Variables for Katib Components" page
3 participants