Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused katib-manager-rest #876

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Remove unused katib-manager-rest #876

merged 1 commit into from
Oct 14, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Oct 11, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@johnugeorge
Copy link
Member

I think, this will be useful to use rest calls for our DB interface. Mostly for debugging I guess, WHYT?

@hougangliu
Copy link
Member Author

for now, only metrics related operations (create/delete/get) are available. I think the rest service is of little value now.

@hougangliu hougangliu changed the title Remove unsed katib-manager-rest Remove unused katib-manager-rest Oct 11, 2019
@gaocegege
Copy link
Member

SGTM

/lgtm

@hougangliu
Copy link
Member Author

@johnugeorge
katib-manager-rest is introduced in v1alpha1 when katib-manager works as a core role by which controller persists studyjob info into db and call it to get suggestion result, 3rd-party can call it to check StudyJob information (katib UI), suggestion service to call it to check trial result or else. by katib-manager-rest, 3rd-party can get studyjob info in REST way.
now, katib-manager just plays an internal DB interface role to persist only metrics and 3rd-party doesn't need it. so katib-manager-rest can say goodbye now.
WDYT?

@johnugeorge
Copy link
Member

Sounds good. Just thinking if it is late to add to 0.7 release?

@hougangliu
Copy link
Member Author

Sounds good. Just thinking if it is late to add to 0.7 release?

The risk is little since the change doesn't change katib-manger, katib-controller and suggestion algorithm code.

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants