-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused katib-manager-rest #876
Conversation
I think, this will be useful to use rest calls for our DB interface. Mostly for debugging I guess, WHYT? |
for now, only metrics related operations (create/delete/get) are available. I think the rest service is of little value now. |
SGTM /lgtm |
@johnugeorge |
Sounds good. Just thinking if it is late to add to 0.7 release? |
The risk is little since the change doesn't change katib-manger, katib-controller and suggestion algorithm code. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-katib-presubmit |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is