Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove katib-manager-rest #516

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Oct 14, 2019

Which issue is resolved by this Pull Request:
Sync up with kubeflow/katib#876
Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@hougangliu
Copy link
Member Author

kubeflow-manifests-presubmit depends on kubeflow/kubeflow#4289, once it merged, this PR test can work well

@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

@richardsliu PTAL. Thanks

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d728e0d into kubeflow:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants