-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata OpenAPI spec #17
Fix metadata OpenAPI spec #17
Conversation
45ba485
to
96c9f30
Compare
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
96c9f30
to
adad89a
Compare
TBD:
|
Given it's a breaking change in the API, we have to bump api version. |
@@ -1102,50 +1102,102 @@ components: | |||
- $ref: "#/components/schemas/MetadataStructValue" | |||
- $ref: "#/components/schemas/MetadataProtoValue" | |||
- $ref: "#/components/schemas/MetadataBoolValue" | |||
discriminator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change!
This is going to improve a lot, the generation of code out of the spec 👍
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
1f714b6
to
8416435
Compare
Addressed both items:
|
If the change looks good, I would suggest to merge with |
/lgtm Thanks a lot @lampajr for the teamwork and the contributions! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* kubeflow: fix go module and odh. debranding (#15) * kubeflow: change go module name and references Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * kubeflow: rename odh. into kfmr. Signed-off-by: tarilabs <matteo.mortari@gmail.com> * kubeflow: py: pyproject description Signed-off-by: tarilabs <matteo.mortari@gmail.com> * kubeflow: nit picks in text documents Signed-off-by: tarilabs <matteo.mortari@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: tarilabs <matteo.mortari@gmail.com> Co-authored-by: tarilabs <matteo.mortari@gmail.com> * Fix metadata OpenAPI spec (#17) * fix: OpenAPI metadata discriminator Signed-off-by: tarilabs <matteo.mortari@gmail.com> * wiring factories and default values missed in codegen Signed-off-by: tarilabs <matteo.mortari@gmail.com> * introduce openapi defaults Signed-off-by: tarilabs <matteo.mortari@gmail.com> * fix TestMetadataValue* Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * fix: type assert generation Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * upgrade openapi spec version to v1alpha2 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: tarilabs <matteo.mortari@gmail.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: tarilabs <matteo.mortari@gmail.com> * kubeflow: make MLMD type names (and prefix) pluggable (#19) Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#20) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.61.1...v1.62.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OAS: Fix discriminator field definition for Artifact (#22) * gitignore: ignore all coverage files Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> * OAS: fix discriminator field for Artifact Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: tarilabs <matteo.mortari@gmail.com> Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Isabella Basso <idoamara@redhat.com>
Description
This PR aims to improve the openapi spec for
MetadataValue
by properly using thediscriminator
.How Has This Been Tested?
Checking the generated models and server are correctly bootstrapped
Then by running both
unit
androbot
tests:make test
and
Merge criteria: