-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add kfp-tekton integration tests and manifests #10702
Conversation
/hold Wait for tests to pass before ask for review/approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments on the registry name.
manifests/kustomize/env/platform-agnostic-tekton-multi-user/kustomization.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/env/platform-agnostic-tekton/kustomization.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/third-party/tekton-custom-task/driver-controller/500-controller.yaml
Outdated
Show resolved
Hide resolved
manifests/kustomize/third-party/tekton-custom-task/driver-controller/200-serviceaccount.yaml
Outdated
Show resolved
Hide resolved
d26397a
to
587e602
Compare
Test are failling because some resources don't have namespace explicitly set. Some examples: I tried to find a way to set in the kustomization.yaml level to set namespace in the objects that don't have namespace set but no luck. That being said, I'd like to ask @Tomcli and @chensun :
|
b9f1d7d
to
f7c638d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments on fixing the old kustomize code to kustomize 5.2.1
manifests/kustomize/env/platform-agnostic-tekton-multi-user/kustomization.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think you didn't copy some role permission from the persistent agent, so the end to end test wasn't able to update the run status.
...ts/kustomize/third-party/tekton/upstream/manifests/base/tektoncd-install/tekton-release.yaml
Outdated
Show resolved
Hide resolved
Thank you for that! I'm still trying to figure you why the flip coin pipeline never finishes. At least with that change I can see the pipeline status of RUNNING, but it stays in that status until failure. |
2764782
to
1501193
Compare
Just a checkpoint comment: Tests are passing, but I still need to address Tommy's comment on Kustomize 5.2.1 support and the re-tag script. |
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed through the integration test results in CI and verified they work as expected.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chensun Looks like e2e test did not finish well, but unrelated to the PR. Should we try run again? |
/test kubeflow-pipeline-e2e-test |
See kubeflow/pipelines#10702 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Update kubeflow/pipelines manifests from 2.2.0 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update sync-pipelines-manifests.sh Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update kubeflow/pipelines manifests from 2.2.0 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Delete sync-kfp-tekton-manifests.sh See kubeflow/pipelines#10702 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Update kubeflow/pipelines manifests from 2.2.0 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update sync-pipelines-manifests.sh Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update kubeflow/pipelines manifests from 2.2.0 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Delete sync-kfp-tekton-manifests.sh See kubeflow/pipelines#10702 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Description of your changes:
Solves #10489
Adds the kfp-tekton integration tests and corresponding manifests
Checklist: