-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added @rimolive, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions #10963
Conversation
.github/OWNERS
Outdated
- zijianjoy | ||
- rimolive | ||
- hbelmiro | ||
- DharmitD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Fix EoF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
scripts/OWNERS
Outdated
- zijianjoy | ||
- rimolive | ||
- hbelmiro | ||
- DharmitD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Fix EoF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick but otherwise,
/lgtm
@hbelmiro thank you for making this PR on our behalf! :)
9dd4195
to
3383ba6
Compare
…ewers for GitHub Actions. Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you all for your contribution on migration the tests!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds @rimolive, @hbelmiro and @DharmitD as approvers and reviewers for GitHub Actions.
They have been working on migrating tests from Prow to GitHub Actions.
PRs:
Checklist: