Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): removed duplicate function. Fixes #6586 #6594

Conversation

KausthubK
Copy link
Contributor

@KausthubK KausthubK commented Sep 22, 2021

Description of your changes:
Removed duplicate fn as recommended by upstream issue #6586

Checklist:

@google-oss-robot
Copy link

Hi @KausthubK. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun
Copy link
Member

chensun commented Sep 22, 2021

/ok-to-test

@chensun
Copy link
Member

chensun commented Sep 22, 2021

Hi @KausthubK, can you please add an entry in the release note under "Current version": https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

@NikeNano
Copy link
Member

/lgtm

@KausthubK
Copy link
Contributor Author

Hi @KausthubK, can you please add an entry in the release note under "Current version": https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

Done.

@chensun
Copy link
Member

chensun commented Sep 22, 2021

/lgtm
/approve

Thanks!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 8b55b16 into kubeflow:master Sep 22, 2021
@KausthubK KausthubK deleted the fix/sdk-duplicate-function-in-client branch September 22, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants