Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): removed duplicate function. Fixes #6586 #6594

Merged
merged 2 commits into from
Sep 22, 2021
Merged

fix(sdk): removed duplicate function. Fixes #6586 #6594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce22e9e
fix(sdk): removed duplicate list_pipeline_versions function [ fixes #…
KausthubK Sep 21, 2021
fbf54dc
sdk RELEASE.md: update SDK RELEASE note bugfix log
KausthubK Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
## Deprecations

## Bug Fixes and Other Changes
* Fix duplicate function for `list_pipeline_versions()`. [\#6594](https://github.com/kubeflow/pipelines/pull/6594)

## Documentation Updates

Expand Down
23 changes: 0 additions & 23 deletions sdk/python/kfp/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,29 +658,6 @@ def list_pipelines(self, page_token='', page_size=10, sort_by=''):
return self._pipelines_api.list_pipelines(
page_token=page_token, page_size=page_size, sort_by=sort_by)

def list_pipeline_versions(self,
pipeline_id: str,
page_token='',
page_size=10,
sort_by=''):
"""List all versions of a given pipeline.

Args:
pipeline_id: The id of a pipeline.
page_token: Token for starting of the page.
page_size: Size of the page.
sort_by: one of 'field_name', 'field_name desc'. For example, 'name desc'.

Returns:
A response object including a list of pipeline versions and next page token.
"""
return self._pipelines_api.list_pipeline_versions(
resource_key_type="PIPELINE",
resource_key_id=pipeline_id,
page_token=page_token,
page_size=page_size,
sort_by=sort_by)

# TODO: provide default namespace, similar to kubectl default namespaces.
def run_pipeline(
self,
Expand Down