feat(sdk)!: throw error for output_component_file #7390
Conversation
|
/lgtm Looks good! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -91,6 +91,10 @@ def pipeline(): | |||
| Returns: | |||
| A component task factory that can be used in pipeline definitions. | |||
| """ | |||
| if output_component_file is not None: | |||
| raise Exception("output_component_file is not supported yet in v2 early" | |||
There was a problem hiding this comment.
nit: NotImplementedError might be a better choice here than Exception.
No need to create a PR for this, but if we ever touch this file again before we implement it, we may consider updating it.
|
@chensun: GitHub didn't allow me to request PR reviews from the following users: ji-yaqi. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* feat(sdk)!: throw error for output_component_file * Update readme
Description of your changes:
Checklist: