Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk)!: throw error for output_component_file #7390

Merged
merged 2 commits into from
Mar 9, 2022
Merged

feat(sdk)!: throw error for output_component_file #7390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a158d1
feat(sdk)!: throw error for output_component_file
ji-yaqi Mar 9, 2022
f533583
Update readme
ji-yaqi Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* Deprecate v2 compatible mode in v1 compiler. [\#6958](https://github.com/kubeflow/pipelines/pull/6958)
* Drop support for python 3.6 [\#7303](https://github.com/kubeflow/pipelines/pull/7303)
* Deprecate v1 code to deprecated folder [\#7291](https://github.com/kubeflow/pipelines/pull/7291)
* Disable output_component_file temporarily for v2 early release [\#7390](https://github.com/kubeflow/pipelines/pull/7390)

### For Pipeline Authors

Expand Down
4 changes: 4 additions & 0 deletions sdk/python/kfp/components/component_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ def pipeline():
Returns:
A component task factory that can be used in pipeline definitions.
"""
if output_component_file is not None:
raise Exception("output_component_file is not supported yet in v2 early"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: NotImplementedError might be a better choice here than Exception.

No need to create a PR for this, but if we ever touch this file again before we implement it, we may consider updating it.

/cc @ji-yaqi @connor-mccarthy

"releases and will be added back for v2.0.0 ")

if func is None:
return functools.partial(
component,
Expand Down