Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): accept newer typing-extensions versions #7801

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented May 26, 2022

Description of your changes:
Mirrors changes from #7632 in v1.x. Needed to unblock TFX (reference:
#7632 (comment)).

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy force-pushed the accept-newer-typing-extensions-version-on-v1 branch from 0caf5c7 to aafd745 Compare May 26, 2022 21:54
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels May 26, 2022
@connor-mccarthy connor-mccarthy force-pushed the accept-newer-typing-extensions-version-on-v1 branch from aafd745 to 84d2737 Compare May 26, 2022 21:54
@connor-mccarthy connor-mccarthy marked this pull request as ready for review May 26, 2022 21:55
@chensun
Copy link
Member

chensun commented May 27, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ec2f83e into kubeflow:sdk/release-1.8 May 27, 2022
@guimou
Copy link

guimou commented Jun 8, 2022

@connor-mccarthy Hi! Any target for this to be released (in 1.8.13 I guess)?

@connor-mccarthy
Copy link
Member Author

connor-mccarthy commented Jun 8, 2022

Hi @guimou. We have a few more fixes we are looking to include in the 1.8.13 release. I suspect we will be able to release by the end of this month.

@guimou
Copy link

guimou commented Jun 9, 2022

OK, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants