Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Accept newer typing-extensions versions #7632

Merged
merged 3 commits into from
Apr 30, 2022
Merged

feat(sdk): Accept newer typing-extensions versions #7632

merged 3 commits into from
Apr 30, 2022

Conversation

mai-nakagawa
Copy link
Contributor

@mai-nakagawa mai-nakagawa commented Apr 28, 2022 •
edited
Loading

Fixes #7631.

I think it's no problem that the SDK accepts newer typing-extensions versions because:

Starting with version 4.0.0, typing_extensions uses Semantic Versioning. The major version is incremented for all backwards-incompatible changes. Therefore, it’s safe to depend on typing_extensions like this: typing_extensions >=x.y, <(x+1)

@google-oss-prow
Copy link

Hi @mai-nakagawa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mai-nakagawa mai-nakagawa marked this pull request as ready for review April 28, 2022 03:06
@google-oss-prow google-oss-prow bot requested a review from chensun April 28, 2022 03:06
@mai-nakagawa mai-nakagawa changed the title feat(sdk): Upgrade typing-extensions version feat(sdk): Accept newer typing-extensions versions Apr 28, 2022
@connor-mccarthy
Copy link
Member

Thanks for your contribution, @mai-nakagawa! I agree that broadening the pinned typing-extensions version is an improvement. I also agree that this is safe, so long developers ensure any typing-extension features they use also work on Python 3.7 (which is something we do for all other libraries).

/test all

@jgoodman8
Copy link

It would be great to have this feature. We are currently blocked by this due to a compatibility issue. So, it would be awesome if everyone could have a pre-release with this change. Thank you @mai-nakagawa!

@connor-mccarthy
Copy link
Member

@mai-nakagawa, could you please add a bullet in our release notes indicating that we're changing the version?

After that, I think we should be good to merge and it will be included in our alpha.2 release. (cc: @jgoodman8)

@mai-nakagawa
Copy link
Contributor Author

@connor-mccarthy Thanks for your review! Added a description to the release notes by 0faf033.

@connor-mccarthy
Copy link
Member

/lgtm
/approve

Thanks @mai-nakagawa!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1118f48 into kubeflow:master Apr 30, 2022
@jiyongjung0
Copy link
Contributor

Thank you for the PR! I'm working on a project called tfx and we were struggling with conflicting dependencies of typing-extensions. We would be able to resolve the conflict if this change is released.

copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request May 3, 2022
@tfx-copybara
Caps the apache-airflow version to 2.2.x.
15873c3 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446074079
@copybara-service copybara-service bot mentioned this pull request May 3, 2022
Closed
@connor-mccarthy
Copy link
Member

Awesome, @jiyongjung0! Really glad to hear that this is unblocking lots of different projects.

copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request May 3, 2022
@tfx-copybara
Caps the apache-airflow version to 2.2.x.
69eea97 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446074079
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request May 3, 2022
@tfx-copybara
Caps the apache-airflow version to 2.2.x.
56cf3ab 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446074079
@connor-mccarthy connor-mccarthy mentioned this pull request May 3, 2022
Merged
1 task
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request May 3, 2022
@tfx-copybara
Caps the apache-airflow version to 2.2.x.
51f0e57 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446074079
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request May 3, 2022
@tfx-copybara
Caps the apache-airflow version to 2.2.x.
2df92b3 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446236647
jagadeeshi2i pushed a commit to jagadeeshi2i/pipelines that referenced this pull request May 11, 2022
@mai-nakagawa
feat(sdk): Accept newer typing-extensions versions (kubeflow#7632)
3923714 
* Accept newer typing-extensions versions

* Add a description to the release notes.
@rtg0795 rtg0795 mentioned this pull request May 23, 2022
Merged
rtg0795 added a commit to tensorflow/tfx that referenced this pull request May 23, 2022
@rtg0795
Caps the apache-airflow version to 2.2.x. (#4890)
d8bf7d9 
There is a conflicting dependency in apache-airflow 2.3.0
- apache-airflow 1.23.0 -> rich '12.3.0' -> typing-extensions (>=4.0.0,<5.0); python_version < "3.9"
- kfp 1.8.12 -> typing-extensions (<4,>=3.7.4); python_version < "3.9"

This issue will be resolved when kfp releases a new version because kfp already changed the cap in kubeflow/pipelines#7632.

PiperOrigin-RevId: 446236647
(cherry picked from commit 2df92b3)

Co-authored-by: jiyongjung <jiyongjung@google.com>
@jiyongjung0
Copy link
Contributor

Hi, @connor-mccarthy Is there a plan to release a new python package for kfp 1.x? It seems like the package wasn't released for two months and this PR wasn't included in any releases.

@connor-mccarthy connor-mccarthy mentioned this pull request May 25, 2022
Closed
1 task
@connor-mccarthy
Copy link
Member

connor-mccarthy commented May 25, 2022 •
edited
Loading

Hi, @connor-mccarthy Is there a plan to release a new python package for kfp 1.x? It seems like the package wasn't released for two months and this PR wasn't included in any releases.

Hi, @jiyongjung0. Looks like these changes were only applied to v2, but you're working with v1. I have a PR #7801 to mirror these changes in v1 and we can release once that is merged.

This was referenced May 26, 2022
Closed
Merged
Closed
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@mai-nakagawa @abaland
feat(sdk): Accept newer typing-extensions versions (kubeflow#7632)
1253b7a 
* Accept newer typing-extensions versions

* Add a description to the release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

@chensun chensun Awaiting requested review from chensun

Assignees

@connor-mccarthy connor-mccarthy

Labels
approved lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: Accept newer typing-extensions versions
4 participants
@mai-nakagawa @connor-mccarthy @jgoodman8 @jiyongjung0