Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): extract DSL into kfp-dsl package #9738

Merged
merged 5 commits into from
Jul 25, 2023
Merged

chore(sdk): extract DSL into kfp-dsl package #9738

merged 5 commits into from
Jul 25, 2023

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy force-pushed the extract-runtime-package-3 branch 6 times, most recently from f3fdc3d to c6953a5 Compare July 15, 2023 04:37
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy force-pushed the extract-runtime-package-3 branch 2 times, most recently from 57d5120 to ba2375a Compare July 15, 2023 06:00
@connor-mccarthy
Copy link
Member Author

/test all

1 similar comment
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/unhold
/assign @chensun

@connor-mccarthy connor-mccarthy marked this pull request as ready for review July 17, 2023 16:48
@google-oss-prow google-oss-prow bot requested a review from gkcalat July 17, 2023 16:48
@connor-mccarthy connor-mccarthy force-pushed the extract-runtime-package-3 branch 2 times, most recently from 1428db5 to a9222a1 Compare July 17, 2023 19:05
@connor-mccarthy
Copy link
Member Author

/retest

@chensun
Copy link
Member

chensun commented Jul 24, 2023

/retest

chensun
chensun reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sdk/python/install_from_source.sh Show resolved Hide resolved
sdk/python/kfp-dsl/runtime_tests/execute_commands_args_test.py Show resolved Hide resolved
sdk/python/kfp-dsl/runtime_tests/import_objects_test.py Show resolved Hide resolved
sdk/python/kfp-dsl/setup.py Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Jul 25, 2023
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 25, 2023
@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 460ddb3 link false /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chensun
chensun approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jul 25, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 525ff90 into kubeflow:master Jul 25, 2023
This was referenced Jul 26, 2023
Merged
Closed
zijianjoy pushed a commit to zijianjoy/pipelines that referenced this pull request Aug 10, 2023
@connor-mccarthy @zijianjoy
chore(sdk): extract DSL into kfp-dsl package (kubeflow#9738)
e84444a 
* move dsl dir

* make kfp-dsl a package

* make kfp-dsl a package

* additional changes

* address review feedback
connor-mccarthy added a commit to connor-mccarthy/pipelines that referenced this pull request Aug 15, 2023
@connor-mccarthy
revert parts of kubeflow#9738
5692bda
connor-mccarthy added a commit that referenced this pull request Aug 15, 2023
@connor-mccarthy
chore(sdk): undo creation of kfp-dsl namespace package (#9874)
c9e5479 
* revert to c8204d0

* reapply #9742

* modify #9791

* reapply #9800

* reapply #9827

* revert parts of #9738

* reapply parts of #9785

* remove duplicated dsl-test code

* reapply parts of #9791

* correct version
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@connor-mccarthy @stijntratsaertit
chore(sdk): extract DSL into kfp-dsl package (kubeflow#9738)
5baabda 
* move dsl dir

* make kfp-dsl a package

* make kfp-dsl a package

* additional changes

* address review feedback
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@connor-mccarthy @stijntratsaertit
chore(sdk): undo creation of kfp-dsl namespace package (kubeflow#9874)
9604f27 
* revert to c8204d0

* reapply kubeflow#9742

* modify kubeflow#9791

* reapply kubeflow#9800

* reapply kubeflow#9827

* revert parts of kubeflow#9738

* reapply parts of kubeflow#9785

* remove duplicated dsl-test code

* reapply parts of kubeflow#9791

* correct version
@chensun chensun mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@jlyaoyuli jlyaoyuli Awaiting requested review from jlyaoyuli

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@gkcalat gkcalat Awaiting requested review from gkcalat

Assignees

@chensun chensun

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccarthy @chensun