Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): undo creation of kfp-dsl namespace package #9874

Merged
merged 10 commits into from
Aug 15, 2023
Merged

chore(sdk): undo creation of kfp-dsl namespace package #9874

merged 10 commits into from
Aug 15, 2023

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:

Checklist:

@connor-mccarthy
Copy link
Member Author

/test all

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy
Copy link
Member Author

/test all

1 similar comment
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review August 15, 2023 23:14
@connor-mccarthy
Copy link
Member Author

/assign @chensun

chensun
chensun approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

e2e test is probably going to fail due to a known issue, we can ignore it when merging this PR.

@google-oss-prow google-oss-prow bot added the lgtm label Aug 15, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@connor-mccarthy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test 8edc75b link true /test kubeflow-pipeline-e2e-test
kubeflow-pipelines-sdk-execution-tests f9762fb link false /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy merged commit c9e5479 into kubeflow:master Aug 15, 2023
1 check passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@connor-mccarthy @stijntratsaertit
chore(sdk): undo creation of kfp-dsl namespace package (kubeflow#9874)
9604f27 
* revert to c8204d0

* reapply kubeflow#9742

* modify kubeflow#9791

* reapply kubeflow#9800

* reapply kubeflow#9827

* revert parts of kubeflow#9738

* reapply parts of kubeflow#9785

* remove duplicated dsl-test code

* reapply parts of kubeflow#9791

* correct version
@chensun chensun mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@gkcalat gkcalat Awaiting requested review from gkcalat

@jlyaoyuli jlyaoyuli Awaiting requested review from jlyaoyuli

Assignees

@chensun chensun

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-mccarthy @chensun @Linchin