Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-tools to 0.6.0 and enable GenerateEmbeddedObjectMeta #1409

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Sep 20, 2021

Address p0 issue #1403

/cc @andreyvelich @kubeflow/wg-training-leads

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @Jeffwan
/lgtm
/assign @kubeflow/wg-training-leads

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 20, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f9e5004 into kubeflow:master Sep 20, 2021
@Jeffwan Jeffwan deleted the fix_pod_template branch September 20, 2021 20:31
google-oss-robot pushed a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants