-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP update go mod for test #1462
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zw0610 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b299f4
to
aa239f9
Compare
c901942
to
0ce1456
Compare
Pull Request Test Coverage Report for Build 1486667268
💛 - Coveralls |
/retest |
em.. Seems I need to change another dev machine to do the test. git connection is really unstable in CN.
|
/test kubeflow-training-operator-presubmit |
I manually run
|
I think I found the problem. the service label and selector are still using upper case so that's the reason it can not find the underneath pods which makes real testing jobs failed. The reason that
@zw0610 please help update kubeflow/common and let's give another try |
1379ed3
to
ee19d2d
Compare
/close as kubeflow/common#173 is merged. |
This is to test kubeflow/common#173.. Please don't review/approve it.
/hold