Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e failure debugging guidance #1469

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Nov 16, 2021

Follow up on #1462, resolve #1467

/cc @zw0610 @terrytangyuan @kubeflow/wg-training-leads

@coveralls
Copy link

coveralls commented Nov 16, 2021

Pull Request Test Coverage Report for Build 1465494423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.15%

Totals Coverage Status
Change from base Build 1451602229: 0.0%
Covered Lines: 311
Relevant Lines: 3816

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for putting this together!

docs/testing/e2e_debugging.md Outdated Show resolved Hide resolved
sudo cp ks_0.13.1_linux_amd64/ks /usr/local/bin/ks-13
```
> We would like to deprecate `ksonnet` but may takes some time. Feel free to pick up [the issue](https://github.com/kubeflow/training-operator/issues/1468) if you are interested in it.
> If your platform is darwin or windows, feel free to download binaries in [ksonnet v0.13.1](https://github.com/ksonnet/ksonnet/releases/tag/v0.13.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make the URL above more generic, e.g. uname -s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find an easier way to output platform and arch. lowercase() needs to apply on results from uname -s which makes the url not that clean.

docs/testing/e2e_debugging.md Outdated Show resolved Hide resolved
Jeffwan and others added 2 commits November 16, 2021 13:33
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jeffwan,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f75d7fc into kubeflow:master Nov 17, 2021
@Jeffwan Jeffwan deleted the debug_e2e branch November 17, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write down e2e failure debug process
3 participants