Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow predicate checkout of podgroup UpdateFunc #1720

Closed
wants to merge 1 commit into from

Conversation

tsuiot
Copy link

@tsuiot tsuiot commented Jan 11, 2023

What this PR does / why we need it:
when apply paddlepaddleJob with enable gang schedule, that the operator SyncPodGroup and delay pods creation until podgroup status is inqueue, the operator update LastReconcileTime of jobStatus in each reconcile that can trigger next Reconcile.
when the last two LastReconcileTime is same in second, then canot tigger next reconcile in watch loop. and this paddlepaddleJob is always in pendding, unless reboot training-operator pod or modify paddlepaddleJob.
for the above bug, it can tigger by podgroup status change, but OnDependentUpdateFunc in reconciler.go only allow pod/service, my pr is fix to allow tigger event loop by podgroup update

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Jan 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsuiot
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval by writing /assign @gaocegege in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsuiot
Copy link
Author

tsuiot commented Jan 11, 2023

PS: this pull request is 2/2 fix bug of training-operator`s reconcile event loop.
another pr: kubeflow/common#202

@tenzen-y
Copy link
Member

@tsuiot Thanks for reporting this and submitting this patch.
Probably, that bug will be fixed by #1730 since we need to use generic predicates for PodGroup, the same as other controllers.

@johnugeorge
Copy link
Member

johnugeorge commented Jan 19, 2023

Can we close this PR as #1730 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants