fix: allow predicate checkout of podgroup UpdateFunc #1720
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when apply paddlepaddleJob with enable gang schedule, that the operator SyncPodGroup and delay pods creation until podgroup status is inqueue, the operator update LastReconcileTime of jobStatus in each reconcile that can trigger next Reconcile.
when the last two LastReconcileTime is same in second, then canot tigger next reconcile in watch loop. and this paddlepaddleJob is always in pendding, unless reboot training-operator pod or modify paddlepaddleJob.
for the above bug, it can tigger by podgroup status change, but OnDependentUpdateFunc in reconciler.go only allow pod/service, my pr is fix to allow tigger event loop by podgroup update
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: