Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predicates of paddlepaddle-controller for scheduling.volcano.sh/v1beta1 PodGroup #1730

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I fixed predicates of the paddlepaddle-controller for scheduling.volcano.sh/v1beta1 PodGroup.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1729

Checklist:

  • Docs included if any changes are user facing

…1beta1 PodGroup

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 17, 2023

/assign @johnugeorge @terrytangyuan

@google-oss-prow
Copy link

@tenzen-y: GitHub didn't allow me to assign the following users: kuikuikuizzZ.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @kuikuikuizzZ @johnugeorge @terrytangyuan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member Author

/assign @kuizhiqing

@coveralls
Copy link

coveralls commented Jan 17, 2023

Pull Request Test Coverage Report for Build 3940203634

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 39.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.99%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 3 54.84%
Totals Coverage Status
Change from base Build 3936910725: 0.2%
Covered Lines: 2674
Relevant Lines: 6788

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm
/approve

/hold for @kuizhiqing 's review

@kuizhiqing
Copy link
Member

/lgtm
/approve

@tenzen-y Thanks very much !

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, kuizhiqing, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

Thanks for the review!
/hold cancel

@johnugeorge
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 1d88c0e into kubeflow:master Jan 18, 2023
@tenzen-y tenzen-y deleted the fix-predicators branch January 18, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paddle-operator can not get podgroup status(inqueue) with volcano when enable gang
5 participants