-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix predicates of paddlepaddle-controller for scheduling.volcano.sh/v1beta1 PodGroup #1730
Conversation
…1beta1 PodGroup Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
/assign @johnugeorge @terrytangyuan |
@tenzen-y: GitHub didn't allow me to assign the following users: kuikuikuizzZ. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @kuizhiqing |
Pull Request Test Coverage Report for Build 3940203634
💛 - Coveralls |
/lgtm /hold for @kuizhiqing 's review |
/lgtm @tenzen-y Thanks very much ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, kuizhiqing, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review! |
/hold cancel |
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What this PR does / why we need it:
I fixed predicates of the paddlepaddle-controller for scheduling.volcano.sh/v1beta1 PodGroup.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1729
Checklist: