Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Breaking Changes: Upgrade Scheduler Plugins version to v0.25.7 #1824

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 4, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1769

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jun 4, 2023

Pull Request Test Coverage Report for Build 5170402279

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 33.77%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.19%
Totals Coverage Status
Change from base Build 5154044716: -0.2%
Covered Lines: 3322
Relevant Lines: 9837

💛 - Coveralls

@tenzen-y tenzen-y force-pushed the upgrade-scheduler-plugins-version branch 10 times, most recently from 9841650 to 7183fa2 Compare June 4, 2023 17:23
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the upgrade-scheduler-plugins-version branch from 7183fa2 to 31f18fe Compare June 4, 2023 17:40
@tenzen-y tenzen-y changed the title [WIP] ⚠️ Breaking Changes: Upgrade Scheduler Plugins version to v0.25.7 ⚠️ Breaking Changes: Upgrade Scheduler Plugins version to v0.25.7 Jun 8, 2023
@tenzen-y tenzen-y marked this pull request as ready for review June 8, 2023 19:51
@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 8, 2023

/assign @johnugeorge

@johnugeorge
Copy link
Member

Thanks for making this cleaner

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 9, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5a4cf7c into kubeflow:master Jun 9, 2023
@tenzen-y tenzen-y deleted the upgrade-scheduler-plugins-version branch April 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new scheduler-plugins API group
3 participants