⚠️ Breaking Changes: Rename monitoring-port flag to webook-server-port
#1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the flag name for the webhook server port from `monitoringPort` to `webhookServerPort` Signed-off-by: Andreas Fritzler <andreas.fritzler@proton.me>
tenzen-y
reviewed
Oct 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afritzler, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @tenzen-y! Is there a label to mark this change as breaking as mentioned in the PR description? |
afritzler
changed the title
monitoring-port flag to webook-server-portmonitoring-port flag to webook-server-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
monitoring-portflag is wrongly used as the webhook server port. This PR renames themonitoring-portflag towebook-server-port. As this is a potentially breaking change (e.g. when used in Helm charts) this needs to be marked as such.In the pre 0.16.x time of the
controller-runtimethePortconfig is defined here:https://github.com/kubernetes-sigs/controller-runtime/blob/v0.15.2/pkg/manager/manager.go#L287
Checklist:
/cc @tenzen-y