Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed package name to flake8 to fix pytests pip install #2109

Merged
merged 1 commit into from
May 10, 2024

Conversation

ChristopheBrown
Copy link
Contributor

I run into this error trying to pip install for pytest pip install '.[test]':

ERROR: Could not find a version that satisfies the requirement flake==4.0.1; extra == "test" (from kubeflow-training[test]) (from versions: none)
ERROR: No matching distribution found for flake==4.0.1; extra == "test"

When changing the line to "flake8==4.0.1", I get a successful run:

Successfully built kubeflow-training
Installing collected packages: kubeflow-training
  Attempting uninstall: kubeflow-training
    Found existing installation: kubeflow-training 1.7.0
    Uninstalling kubeflow-training-1.7.0:
      Successfully uninstalled kubeflow-training-1.7.0
Successfully installed kubeflow-training-1.7.0

No changes to the version, or anything else really.

@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9032957488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 35.431%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.24%
Totals Coverage Status
Change from base Build 9023459617: 0.05%
Covered Lines: 4380
Relevant Lines: 12362

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristopheBrown Thank you for creating this PR!
Could you sign DCO in the following?

https://github.com/kubeflow/training-operator/pull/2109/checks?check_run_id=24803090584

Signed-off-by: Christophe Brown <cb@Prophecy.home>
@ChristopheBrown
Copy link
Contributor Author

@tenzen-y Followed the steps in the page you linked. Let me know if anything else is needed. Thanks!

@tenzen-y
Copy link
Member

@tenzen-y Followed the steps in the page you linked. Let me know if anything else is needed. Thanks!

Awsome! Thank you!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e31d11f into kubeflow:master May 10, 2024
38 of 39 checks passed
tenzen-y pushed a commit to tenzen-y/training-operator that referenced this pull request Jun 5, 2024
)

Signed-off-by: Christophe Brown <cb@Prophecy.home>
Co-authored-by: Christophe Brown <cb@Prophecy.home>
google-oss-prow bot pushed a commit that referenced this pull request Jun 10, 2024
… pip install (#2140)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants