-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed package name to flake8 to fix pytests pip install #2109
Conversation
Pull Request Test Coverage Report for Build 9032957488Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristopheBrown Thank you for creating this PR!
Could you sign DCO in the following?
https://github.com/kubeflow/training-operator/pull/2109/checks?check_run_id=24803090584
Signed-off-by: Christophe Brown <cb@Prophecy.home>
@tenzen-y Followed the steps in the page you linked. Let me know if anything else is needed. Thanks! |
Awsome! Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… pip install (#2140) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
I run into this error trying to pip install for pytest
pip install '.[test]':
When changing the line to
"flake8==4.0.1",
I get a successful run:No changes to the version, or anything else really.