Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2109: changed package name to flake8 to fix pip install #2140

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 7, 2024

Cherry pick of #2109 on v1.8-branch.
#2109: changed package name to flake8 to fix pip install
For details on the cherry pick process, see the cherry pick requests page.

I stole the commit since #2109 was not signed in CLA...

Copy link

google-cla bot commented Jun 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing June 7, 2024 16:01
@tenzen-y tenzen-y force-pushed the automated-cherry-pick-of-#2109-upstream-v1.8-branch branch from 0cb6048 to 6585c4a Compare June 7, 2024 16:03
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the automated-cherry-pick-of-#2109-upstream-v1.8-branch branch from 6585c4a to bb13060 Compare June 7, 2024 16:09
@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9419963963

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 35.366%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 80.48%
Totals Coverage Status
Change from base Build 8869266420: -0.02%
Covered Lines: 4372
Relevant Lines: 12362

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tenzen-y!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3a360ba into kubeflow:v1.8-branch Jun 10, 2024
39 checks passed
@tenzen-y tenzen-y deleted the automated-cherry-pick-of-#2109-upstream-v1.8-branch branch June 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants