[SDK] Fix Incorrect Events in get_job_logs API #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 9174836408Details
💛 - Coveralls |
droctothorpe
approved these changes
May 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droctothorpe, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tenzen-y
pushed a commit
to tenzen-y/training-operator
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
This was referenced Jun 5, 2024
tenzen-y
pushed a commit
to tenzen-y/training-operator
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
This was referenced Jun 7, 2024
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
#2122: Fix Incorrect Events in get_job_logs API (#2138) * Support Python 3.11 and Drop Python 3.7 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Fix Incorrect Events in get_job_logs API Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed
add_event_to_dictfunction to correctly check key inevents_dictdictionary.I introduced this bug in this commit: b2d9c36.
Also, I made the key as follows:
/assign @kubeflow/wg-training-leads @droctothorpe