Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #2105: Support Python 3.11 and Drop Python 3.7 #2122: Fix Incorrect Events in get_job_logs API #2138

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Automated cherry pick of #2105: Support Python 3.11 and Drop Python 3.7 #2122: Fix Incorrect Events in get_job_logs API #2138

merged 2 commits into from
Jun 10, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 7, 2024 •
edited
Loading

Cherry pick of #2105 #2122 on v1.8-branch.
#2105: Support Python 3.11 and Drop Python 3.7
#2122: Fix Incorrect Events in get_job_logs API

tenzen-y and others added 2 commits June 8, 2024 00:39
@tenzen-y
Support Python 3.11 and Drop Python 3.7
a1a4700 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@andreyvelich @tenzen-y
Fix Incorrect Events in get_job_logs API
251e3e7 
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing June 7, 2024 15:39
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9419605242

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 35.383%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 80.67%
Totals Coverage Status
Change from base Build 8869266420: 0.0%
Covered Lines: 4374
Relevant Lines: 12362
💛 - Coveralls

andreyvelich
andreyvelich reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tenzen-y!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 10, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ce0609f into kubeflow:v1.8-branch Jun 10, 2024
40 checks passed
@tenzen-y tenzen-y deleted the automated-cherry-pick-of-#2105-#2122-upstream-v1.8-branch branch June 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@andreyvelich andreyvelich

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenzen-y @coveralls @andreyvelich