Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ephemeral storage in Katib Config #2315

Merged
merged 5 commits into from
Nov 13, 2020
Merged

Disable ephemeral storage in Katib Config #2315

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8d28dc
Add info about negative values for ephemeral storage
andreyvelich Oct 27, 2020
dbb70a5
Move to one line
andreyvelich Nov 5, 2020
5f39e10
Remove old config
andreyvelich Nov 11, 2020
4c7c55a
Add info
andreyvelich Nov 11, 2020
e63e496
Address comments
andreyvelich Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions content/en/docs/components/katib/katib-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,13 @@ a default value is set automatically.
- `cpu = 500m`
- `ephemeral-storage = 5Gi`

It is possible to not request the `ephemeral-storage` resource for the
metrics collector's container. For example to use
[GKE nodepool autoscalers](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations).
To do that, set the negative values for the `ephemeral-storage` requests and
limits in your Katib config:
You can run your metrics collector container without requesting
the `ephemeral-storage` resource from the Kubernetes cluster.
For instance, if you want to use
[Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations)
for your Katib experiments. To remove the `ephemeral-storage` resource from
the metrics collector container, set the negative values for the
`ephemeral-storage` requests and limits in your Katib config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence looks like it starts with "if" and doesn't end.

Maybe you can try this, if I understood the logic correctly:

Suggested change
For instance, if you want to use
[Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations)
for your Katib experiments. To remove the `ephemeral-storage` resource from
the metrics collector container, set the negative values for the
`ephemeral-storage` requests and limits in your Katib config:
For instance, when using the
[Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations)
for your Katib experiments, you can remove the `ephemeral-storage` resource from
the metrics collector container by setting the negative values for the
`ephemeral-storage` requests and limits in your Katib config as follows:

WDYT?


```json
"requests": {
Expand Down Expand Up @@ -220,11 +222,13 @@ a default value is set automatically.
- `cpu = 500m`
- `ephemeral-storage = 5Gi`

It is possible to not request the `ephemeral-storage` resource for the
suggestion's container. For example to use
[GKE nodepool autoscalers](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations).
To do that, set the negative values for the `ephemeral-storage` requests and
limits in your Katib config:
You can run your suggestion container without requesting
the `ephemeral-storage` resource from the Kubernetes cluster.
For instance, if you want to use
[Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations)
for your Katib experiments. To remove the `ephemeral-storage` resource from
the suggestion container, set the negative values for the
`ephemeral-storage` requests and limits in your Katib config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the comment before - PTAL


```json
"requests": {
Expand Down