Disable ephemeral storage in Katib Config #2315
Conversation
|
@andreyvelich: GitHub didn't allow me to assign the following users: kylepad. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change is |
andreyvelich
force-pushed
the
issue-1358-disable-ephemeral-storage
branch
from
301149a
to
5f39e10
Compare
andreyvelich
changed the title
|
This PR is ready |
| It is possible to not request the `ephemeral-storage` resource for the | ||
| metrics collector's container. For example to use | ||
| [GKE nodepool autoscalers](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations). | ||
| To do that, set the negative values for the `ephemeral-storage` requests and | ||
| limits in your Katib config: |
There was a problem hiding this comment.
The second sentence is not complete, I think.
The third sentence is not clear about what "that" is.
Can you revise them please?
There was a problem hiding this comment.
Sure, @8bitmp3.
What do you think about this:
You can run your metrics collector container without requesting
the `ephemeral-storage` resource from the Kubernetes cluster.
For instance, if you want to use
[Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations)
for your Katib experiments. To remove the `ephemeral-storage` resource from
the metrics collector container, set the negative values for the
`ephemeral-storage` requests and limits in your Katib config:
| suggestion's container. For example to use | ||
| [GKE nodepool autoscalers](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations). | ||
| To do that, set the negative values for the `ephemeral-storage` requests and | ||
| limits in your Katib config: |
There was a problem hiding this comment.
| For instance, if you want to use | ||
| [Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations) | ||
| for your Katib experiments. To remove the `ephemeral-storage` resource from | ||
| the metrics collector container, set the negative values for the | ||
| `ephemeral-storage` requests and limits in your Katib config: |
There was a problem hiding this comment.
This sentence looks like it starts with "if" and doesn't end.
Maybe you can try this, if I understood the logic correctly:
| For instance, if you want to use | |
| [Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations) | |
| for your Katib experiments. To remove the `ephemeral-storage` resource from | |
| the metrics collector container, set the negative values for the | |
| `ephemeral-storage` requests and limits in your Katib config: | |
| For instance, when using the | |
| [Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations) | |
| for your Katib experiments, you can remove the `ephemeral-storage` resource from | |
| the metrics collector container by setting the negative values for the | |
| `ephemeral-storage` requests and limits in your Katib config as follows: |
WDYT?
| For instance, if you want to use | ||
| [Google Kubernetes Engine cluster autoscaler](https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler#limitations) | ||
| for your Katib experiments. To remove the `ephemeral-storage` resource from | ||
| the suggestion container, set the negative values for the | ||
| `ephemeral-storage` requests and limits in your Katib config: |
There was a problem hiding this comment.
Same as the comment before - PTAL
|
Thank you and please assign/ping the Katib approvers here 👍 I'm not sure I'm part of OWNERS here |
|
Thanks @8bitmp3. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Fixes: kubeflow/katib#1358.
Blocked by: #2312.
I added info about disabling ephemeral storage for suggestion and metrics collector container.
/assign @gaocegege @johnugeorge @kylepad
/cc @8bitmp3